Skip to content

ROSAENG-65393: chore: enable Go version management via .ci-operator.yaml - #83850

Open
cdoan1 wants to merge 1 commit into
openshift:mainfrom
cdoan1:ROSAENG-65393-update-cli-root-image
Open

ROSAENG-65393: chore: enable Go version management via .ci-operator.yaml#83850
cdoan1 wants to merge 1 commit into
openshift:mainfrom
cdoan1:ROSAENG-65393-update-cli-root-image

Conversation

@cdoan1

@cdoan1 cdoan1 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Switch build_root from project_image to from_repository, allowing the project to manage its own Go version through .ci-operator.yaml in the repository.

Summary by CodeRabbit

  • Updates the ROSA HyperFleet CLI CI configuration to build from the repository with from_repository: true.
  • This allows the repository’s .ci-operator.yaml file to manage the Go version instead of using a fixed project_image Dockerfile.

Switch build_root from project_image to from_repository, allowing the project to manage its own Go version through .ci-operator.yaml in the repository.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci-robot

openshift-ci-robot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@cdoan1: This pull request references ROSAENG-65393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Switch build_root from project_image to from_repository, allowing the project to manage its own Go version through .ci-operator.yaml in the repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2026
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2026
@openshift-ci
openshift-ci Bot requested review from jmelis and typeid August 22, 2026 16:43
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1dc8de2b-e1b4-444f-8fa5-e9a10e3b3a3c

📥 Commits

Reviewing files that changed from the base of the PR and between 3fdab29 and bcd07d2.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-online/rosa-hyperfleet-cli/openshift-online-rosa-hyperfleet-cli-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-hyperfleet-cli/openshift-online-rosa-hyperfleet-cli-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The build configuration now sources build_root directly from the repository instead of using a project image Dockerfile path.

Changes

Build configuration

Layer / File(s) Summary
Repository build root
ci-operator/config/openshift-online/rosa-hyperfleet-cli/openshift-online-rosa-hyperfleet-cli-main.yaml
build_root now uses from_repository: true and removes the project_image Dockerfile path.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🟡 Moderate · up to bcd07

This change updates the repository’s CI configuration, but generated job definitions may remain out of sync and cause CI behavior to differ from the configuration. Run make update and include any resulting changes before merging.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: enabling Go version management through .ci-operator.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff changes only CI build configuration and sparse checkout settings; it adds no Ginkgo tests or dynamic test titles.
Test Structure And Quality ✅ Passed The commit changes only two YAML files; no Ginkgo test code or It blocks changed, so the stated test-quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed The PR changes only ci-operator configuration and generated presubmit metadata; it adds no Ginkgo e2e tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only CI YAML and generated presubmit configuration; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only changes ci-operator build configuration and presubmit checkout settings; it adds no deployment, controller, or topology scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The commit changes only CI YAML files and adds no Go, OTE, suite setup, or process-level stdout write.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only CI YAML and generated presubmit YAML; no Ginkgo e2e tests or IPv4/external-connectivity logic was added.
No-Weak-Crypto ✅ Passed The diff changes only CI build-root and presubmit checkout configuration; added lines contain no weak-crypto algorithms, custom crypto, or secret/token comparisons.
Container-Privileges ✅ Passed The PR changes build configuration and sparse checkout only; changed manifests contain none of the specified privilege, host namespace, capability, or escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only build-root selection and sparse checkout entries; no logging statements or sensitive values are added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@cdoan1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-online-rosa-hyperfleet-cli-main-lint openshift-online/rosa-hyperfleet-cli presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-hyperfleet-cli-main-test openshift-online/rosa-hyperfleet-cli presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-hyperfleet-cli-main-verify openshift-online/rosa-hyperfleet-cli presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cdoan1

cdoan1 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cdoan1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gdbranco

Copy link
Copy Markdown
Contributor

/lgtm

/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2026
@openshift-ci

openshift-ci Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoan1, gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cdoan1

cdoan1 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cdoan1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cdoan1

cdoan1 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cdoan1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cdoan1

cdoan1 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cdoan1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cdoan1

cdoan1 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cdoan1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

@cdoan1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants